Re: [ANNOUNCE] Git v2.16.0-rc0

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Jun 14, 2018, 18:55 UTC
Message-ID: <20180614185522.GA255581@aiede.svl.corp.google.com>
In-Reply-To: <20180614183018.GA1911@sigill.intra.peff.net>

Hi,

Sorry for the slow replies. I was out of office earlier and am back now.

Jeff King wrote:

> On Tue, Jun 12, 2018 at 09:29:13AM -0700, Junio C Hamano wrote:
>> Jeff King <peff@peff.net> writes:

>>> To be honest, I could easily see an argument that I _should_ be setting
>>> GIT_SSH_VARIANT to explain what my wrapper is expecting, even though it
>>> happened to work before.

Yes, I encourage anyone setting GIT_SSH to also set GIT_SSH_VARIANT. This way, there can be no confusion about what the setter intends.

The autodetection is in the category of "necessary evil" that wouldn't exist if we were starting over.

[...]

Show 7 quoted lines

> No, my wrapper _isn't_ simple. It passes most options to openssh, but
> just doesn't understand the "-G" probing.  So if the default was
> openssh-like instead of "simple", then that would work fine without me
> setting anything, just like it did before.
>
> Which I thought was where the discussion ended up, but perhaps I'm
> misunderstanding.

Do you mean that it doesn't pass "-G" through, or that when using old versions of openssh that doesn't support "-G" the probing fails?

If the former, then detecting the wrapper as something other than "ssh" is intended behavior (though we might want to change what that something is, as discussed in the previous thread). If the latter, then this is https://crbug.com/git/7 which I consider to be a bug.

[...]

> So I'm OK if we just leave it as-is. It's mostly that I dug into the
> thread and was left with the impression that it was an unfinished
> leftover that we meant to do.

[...]

Show 10 quoted lines

>> In any case, from where I sit, I am still waiting for this offer
>> by Jonathan
>>
>>> It's good you caught this flaw in the detection.  Would something like
>>> the following make sense?  If so, I can resend with a commit message
>>> and tests tomorrow or the day after.
>>
>> to be followed up ;-)
>
> Yes, that was the part that left the impression. :)

Thanks for the poke.

The patch [1] didn't leave me super happy, since it means there is yet another ssh variant for people to understand, in order to accomodate an old version of OpenSSH that is going to go away eventually. In Debian, modern versions of git declare an incompatibility with old versions of OpenSSH in their package metadata to avoid this issue.

In my defense, I said "If so" and no one seemed too enthusiastic about the patch making sense. ;-)

I'll take another look and probably resend.

Sincerely, Jonathan

[1] https://public-inbox.org/git/20180103050730.GA87855@aiede.mtv.corp.google.com/