git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] t5526: test recursive submodules when fetching moved submodules

From
Stefan Beller <sbeller@google.com>
Date
Jun 14, 2018, 17:37 UTC
Message-ID
<20180614173730.205646-1-sbeller@google.com>
In-Reply-To
<20180614173107.201885-1-sbeller@google.com>

The topic merged in 0c7ecb7c311 (Merge branch 'sb/submodule-move-nested', 2018-05-08) provided support for moving nested submodules.

Remove the NEEDSWORK comment and implement the nested submodules test as the comment hinted at.

Signed-off-by: Stefan Beller <sbeller@google.com>
---
I found this when digging around for the previous patch.

Thanks, Stefan

 t/t5526-fetch-submodules.sh | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/t/t5526-fetch-submodules.sh b/t/t5526-fetch-submodules.sh
index 9cc4b569c05..359e03ff836 100755
--- a/t/t5526-fetch-submodules.sh
+++ b/t/t5526-fetch-submodules.sh
@@ -574,11 +574,7 @@ test_expect_success "fetch new commits when submodule got renamed" '
 	git clone . downstream_rename &&
 	(
 		cd downstream_rename &&
-		git submodule update --init &&
-# NEEDSWORK: we omitted --recursive for the submodule update here since
-# that does not work. See test 7001 for mv "moving nested submodules"
-# for details. Once that is fixed we should add the --recursive option
-# here.
+		git submodule update --init --recursive &&
 		git checkout -b rename &&
 		git mv submodule submodule_renamed &&
 		(
-- 
2.18.0.rc1.244.gcf134e6275-goog
Previous: Stefan BellerNext: Heiko Voigt
Message 8 of 12 in “BUG: submodule code prints '(null)'”
  1. Duy NguyenJun 5, 2018
  2. Kaartic SivaraamJun 6, 2018
  3. Duy NguyenJun 9, 2018
  4. Stefan BellerJun 11, 2018
  5. Heiko VoigtJun 14, 2018
  6. Duy NguyenJun 14, 2018
  7. submodule: fix NULL correctness in renamed broken submodulesStefan Beller, Jun 14, 2018
  8. t5526: test recursive submodules when fetching moved submodulesStefan Beller, Jun 14, 2018
  9. Heiko VoigtJun 14, 2018
  10. Heiko VoigtJun 14, 2018
  11. Kaartic SivaraamJun 17, 2018
  12. Stefan BellerJun 12, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.