Re: [RFC PATCH v2 2/4] git-credential-netrc: minor whitespace cleanup in test script
- From
Todd Zullinger <tmz@pobox.com>
- Date
- Jun 13, 2018, 17:21 UTC
- Message-ID
- <20180613172111.GH3094@zaya.teonanacatl.net>
- In-Reply-To
- <CAPig+cRcPD9vh1WMX7UkiD9R_A-DrybvOYwi3R8U2bskfOV_1w@mail.gmail.com>
Eric Sunshine wrote:
Show 28 quoted lines
> On Tue, Jun 12, 2018 at 11:10 PM, Todd Zullinger <tmz@pobox.com> wrote: >> Signed-off-by: Todd Zullinger <tmz@pobox.com> >> --- >> diff --git a/contrib/credential/netrc/t-git-credential-netrc.sh b/contrib/credential/netrc/t-git-credential-netrc.sh >> index 58191a62f8..c5661087fe 100755 >> --- a/contrib/credential/netrc/t-git-credential-netrc.sh >> +++ b/contrib/credential/netrc/t-git-credential-netrc.sh >> @@ -17,15 +17,15 @@ >> # set up test repository >> >> test_expect_success \ >> - 'set up test repository' \ >> - 'git config --add gpg.program test.git-config-gpg' >> + 'set up test repository' \ >> + 'git config --add gpg.program test.git-config-gpg' > > Since you're touching all the tests in this script anyhow, perhaps > modernize them so the title and opening quote of the test body are on > the same line as test_expect_success, and the closing body quote is on > a line of its own? > > test_expect_sucess 'setup test repository' ' > ...test body... > ' > > I also changed "set up" to "setup" to follow existing practice. > > (Not necessarily worth a re-roll.)
These tests were based on similar test_external tests which use perl. like t0202 & t9700. Both examples use the same formatting (and use of 'set up'). Perhaps a later clean up can adjust all three tests?
--
Todd
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
How can I tell that the past isn't a fiction designed to account for
the discrepancy between my immediate physical sensation and my state
of mind?
-- Douglas Adams