git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] fsck: avoid looking at NULL blob->object

From
Jeff King <peff@peff.net>
Date
Jun 9, 2018, 09:21 UTC
Message-ID
<20180609092135.GC6817@sigill.intra.peff.net>
In-Reply-To
<CAN0heSqHRpOerHV8tgA-ntU6QvYQMxgrXPCPsrVcHLKUSwANXQ@mail.gmail.com>
On Sat, Jun 09, 2018 at 10:50:36AM +0200, Martin Ågren wrote:
Show 7 quoted lines
> On 9 June 2018 at 10:32, Jeff King <peff@peff.net> wrote:
> > Except it _does_ do one non-trivial thing, which is call the
> > report() function, which wants us to pass a pointer to a
> > "struct object". Which we don't have (we have only a "struct
> > object_id"). So we erroneously passed the NULL object, which
> 
> s/passed/dereferenced/? Probably doesn't affect the fix though.
Well, we passed it, and then that function dereferenced it. :)

I'm going to re-roll for the minor bits that Eric pointed out, so I'll try to word this better.

-Peff
Previous: Martin ÅgrenNext: Martin Ågren
Message 7 of 17 in “fsck: avoid looking at NULL blob->object”
  1. fsck: avoid looking at NULL blob->objectJeff King, Jun 9, 2018
  2. Eric SunshineJun 9, 2018
  3. Jeff KingJun 9, 2018
  4. Duy NguyenJun 9, 2018
  5. Jeff KingJun 9, 2018
  6. Martin ÅgrenJun 9, 2018
  7. Jeff KingJun 9, 2018
  8. Martin ÅgrenJun 9, 2018
  9. Jeff KingJun 12, 2018
  10. 0/2 .gitmodules fsck cleanupsJeff King, Jun 9, 2018
  11. 1/2 t7415: don't bother creating commit for symlink testJeff King, Jun 9, 2018
  12. SZEDER GáborJun 9, 2018
  13. 0/2 .gitmodules fsck cleanupsJeff King, Jun 11, 2018
  14. 1/2 t7415: don't bother creating commit for symlink testJeff King, Jun 11, 2018
  15. 2/2 fsck: avoid looking at NULL blob->objectJeff King, Jun 11, 2018
  16. 2/2 fsck: avoid looking at NULL blob->objectJeff King, Jun 9, 2018
  17. SZEDER GáborJun 9, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.