[PATCHv2 5/6] git-p4: narrow the scope of exceptions caught when parsing an int

From: Luke Diamand <luke@diamand.org>
Date: Jun 8, 2018, 20:32 UTC
Message-ID: <20180608203248.16311-6-luke@diamand.org>
In-Reply-To: <20180608203248.16311-5-luke@diamand.org>

The current code traps all exceptions around some code which parses an integer, and then talks to Perforce.

That can result in errors from Perforce being ignored. Change the code to only catch the integer conversion exceptions.

Signed-off-by: Luke Diamand <luke@diamand.org>
---
 git-p4.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/git-p4.py b/git-p4.py
index f4b5deeb83..5f59feb5bb 100755
--- a/git-p4.py
+++ b/git-p4.py
@@ -959,7 +959,7 @@ def p4ChangesForPaths(depotPaths, changeRange, requestedBlockSize):
         try:
             (changeStart, changeEnd) = p4ParseNumericChangeRange(parts)
             block_size = chooseBlockSize(requestedBlockSize)
-        except:
+        except ValueError:
             changeStart = parts[0][1:]
             changeEnd = parts[1]
             if requestedBlockSize:

-- 
2.17.0.392.gdeb1a6e9b7