git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] format-patch: clear UNINTERESTING flag before prepare_bases

From
EHEduardo Habkost <ehabkost@redhat.com>
Date
Jun 4, 2018, 19:42 UTC
Message-ID
<20180604194241.GV7451@localhost.localdomain>
In-Reply-To
<20180604150543.7304-1-xiaolong.ye@intel.com>
On Mon, Jun 04, 2018 at 11:05:43PM +0800, Xiaolong Ye wrote:
Show 9 quoted lines
> When users specify the commit range with 'Z..C' pattern for format-patch, all
> the parents of Z (including Z) would be marked as UNINTERESTING which would
> prevent revision walk in prepare_bases from getting the prerequisite commits,
> thus `git format-patch --base <base_commit_sha> Z..C` won't be able to generate
> the list of prerequisite patch ids. Clear UNINTERESTING flag with
> clear_object_flags solves this issue.
> 
> Reported-by: Eduardo Habkost <ehabkost@redhat.com>
> Signed-off-by: Xiaolong Ye <xiaolong.ye@intel.com>
Thanks!  The fix works for me.
Tested-by: Eduardo Habkost <ehabkost@redhat.com>
-- 
Eduardo
Previous: Xiaolong YeNext: Ye Xiaolong
Message 7 of 9 in “format-patch: no 'prerequisite-patch-id' info when specifying commit range”
  1. Eduardo HabkostMay 29, 2018
  2. Ye XiaolongMay 30, 2018
  3. Ye XiaolongJun 3, 2018
  4. Junio C HamanoJun 4, 2018
  5. Ye XiaolongJun 4, 2018
  6. format-patch: clear UNINTERESTING flag before prepare_basesXiaolong Ye, Jun 4, 2018
  7. Eduardo HabkostJun 4, 2018
  8. Ye XiaolongJun 19, 2018
  9. Stefan BellerJun 19, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.