git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/2] index-pack out-of-repo fixups

From
Jeff King <peff@peff.net>
Date
May 31, 2018, 22:39 UTC
Message-ID
<20180531223901.GA18999@sigill.intra.peff.net>

Coverity reported that the recently-added call to add_packed_git() in index-pack.c actually does nothing. It's right, and it turns out this is a minor bug in the .gitmodules fsck patches in v2.17.1. I say minor because it errs on the side of complaining too much (so it's not a security problem) and it comes up only in what I can imagine is a pretty obscure case.

The second patch here fixes that. But while looking into it, I notice a much older breakage in running "index-pack --strict" outside of a repository entirely. That's fixed by the first patch.

  [1/2]: prepare_commit_graft: treat non-repository as a noop
  [2/2]: index-pack: handle --strict checks of non-repo packs
 builtin/index-pack.c       |  8 ++++++--
 commit.c                   |  3 +++
 t/t5300-pack-object.sh     |  6 ++++++
 t/t7415-submodule-names.sh | 10 ++++++++++
 4 files changed, 25 insertions(+), 2 deletions(-)
-Peff
Next: Jeff King
Message 1 of 3 in “index-pack out-of-repo fixups”
  1. 0/2 index-pack out-of-repo fixupsJeff King, May 31, 2018
  2. 1/2 prepare_commit_graft: treat non-repository as a noopJeff King, May 31, 2018
  3. 2/2 index-pack: handle --strict checks of non-repo packsJeff King, May 31, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.