Re: [PATCH 1/3] refs/packed-backend.c: close fd of empty file

From: Jeff King <peff@peff.net>
Date: May 31, 2018, 05:15 UTC
Message-ID: <20180531051546.GA17068@sigill.intra.peff.net>
In-Reply-To: <20180530170302.191176-1-sbeller@google.com>

On Wed, May 30, 2018 at 10:03:00AM -0700, Stefan Beller wrote:

Show 12 quoted lines

> diff --git a/refs/packed-backend.c b/refs/packed-backend.c
> index cec3fb9e00f..d447a731da0 100644
> --- a/refs/packed-backend.c
> +++ b/refs/packed-backend.c
> @@ -499,6 +499,7 @@ static int load_contents(struct snapshot *snapshot)
>  	size = xsize_t(st.st_size);
>  
>  	if (!size) {
> +		close(fd);
>  		return 0;
>  	} else if (mmap_strategy == MMAP_NONE || size <= SMALL_FILE_SIZE) {
>  		snapshot->buf = xmalloc(size);

Yep, this is definitely correct. Good catch.

-Peff