Re: js/empty-config-section-fix, was Re: What's cooking in git.git (May 2018, #03; Wed, 23)

From: Jeff King <peff@peff.net>
Date: May 29, 2018, 16:49 UTC
Message-ID: <20180529164912.GA13385@sigill.intra.peff.net>
In-Reply-To: <nycvar.QRO.7.76.6.1805281319530.82@tvgsbejvaqbjf.bet>

On Mon, May 28, 2018 at 01:20:41PM +0200, Johannes Schindelin wrote:

Show 24 quoted lines

> On Mon, 28 May 2018, Junio C Hamano wrote:
> 
> > Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> > 
> > > On Thu, 24 May 2018, Junio C Hamano wrote:
> > >
> > >> * js/empty-config-section-fix (2018-05-18) 1 commit
> > >>  - config: a user-provided invalid section is not a BUG
> > >> 
> > >>  Error codepath fix.
> > >> 
> > >>  Will merge to 'next'.
> > >
> > > As a hotfix, maybe we can fast-track it to master?
> > 
> > Hotfix is a proposed fix for an issue that is so important to be a
> > showstopper.  This one must be fixed before the final release, but I
> > do not think it's not that urgent to force us to drop everything
> > else and merge it to master immediately.
> 
> Well, in this case, a user might report a BUG when they simply have an
> invalid config.
> 
> I do not care all that much, but Peff (who reported this) might.

I think it's fine to just fix it before release. Both the likelihood of it happening and its severity are pretty low.

-Peff