Re: [PATCH] t7005-editor: get rid of the SPACES_IN_FILENAMES prereq

From: Jeff King <peff@peff.net>
Date: May 18, 2018, 21:39 UTC
Message-ID: <20180518213903.GC21797@sigill.intra.peff.net>
In-Reply-To: <20180514102812.7924-1-szeder.dev@gmail.com>

On Mon, May 14, 2018 at 12:28:12PM +0200, SZEDER Gábor wrote:

Show 8 quoted lines

> The last two tests 'editor with a space' and 'core.editor with a
> space' in 't7005-editor.sh' need the SPACES_IN_FILENAMES prereq to
> ensure that they are only run on filesystems that allow, well, spaces
> in filesnames.  However, we have been putting a space in the name of
> the trash directory for just over a decade now, so we wouldn't be able
> to run any of our tests on such a filesystem in the first place.
> 
> This prereq is therefore unnecessary, remove it.

I wondered if there might be some platforms that tweak the test environment in such a way that we skip the space in "trash directory". But looking at test-lib.sh, I don't think there is any easy way to do so (e.g., you can't just set $TEST_DIRECTORY_NAME or something). So this does seem safe, and it's nice to reduce unnecessary complexity.

-Peff