git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 3/3] Inform about fast-forwarding of submodules during merge

From
Stefan Beller <sbeller@google.com>
Date
May 15, 2018, 20:00 UTC
Message-ID
<20180515200030.88731-6-sbeller@google.com>
In-Reply-To
<20180515200030.88731-1-sbeller@google.com>
From: Leif Middelschulte <Leif.Middelschulte@gmail.com>

Inform the user about an automatically fast-forwarded submodule. The silent merge behavior was introduced by commit 68d03e4a6e44 ("Implement automatic fast-forward merge for submodules", 2010-07-07)).

Signed-off-by: Leif Middelschulte <Leif.Middelschulte@gmail.com>
Signed-off-by: Stefan Beller <sbeller@google.com>
---
 merge-recursive.c | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)
diff --git a/merge-recursive.c b/merge-recursive.c
index 0571919ee0a..29a430c418a 100644
--- a/merge-recursive.c
+++ b/merge-recursive.c
@@ -1093,10 +1093,26 @@ static int merge_submodule(struct merge_options *o,
 	/* Case #1: a is contained in b or vice versa */
 	if (in_merge_bases(commit_a, commit_b)) {
 		oidcpy(result, b);
+		if (show(o, 3)) {
+			output(o, 1, _("Fast-forwarding submodule %s to the following commit:"), path);
+			output_commit_title(o, commit_b);
+		} else if (show(o, 2))
+			output(o, 2, _("Fast-forwarding submodule %s to %s"), path, oid_to_hex(b));
+		else
+			; /* no output */
+
 		return 1;
 	}
 	if (in_merge_bases(commit_b, commit_a)) {
 		oidcpy(result, a);
+		if (show(o, 3)) {
+			output(o, 1, _("Fast-forwarding submodule %s to the following commit:"), path);
+			output_commit_title(o, commit_a);
+		} else if (show(o, 2))
+			output(o, 2, _("Fast-forwarding submodule %s to %s"), path, oid_to_hex(a));
+		else
+			; /* no output */
+
 		return 1;
 	}
 
-- 
2.17.0.582.gccdcbd54c44.dirty
Previous: Junio C HamanoNext: Elijah Newren
Message 5 of 19 in “[PATCHv2 0/3] Reroll of sb/submodule-merge-in-merge-recursive”
  1. Stefan BellerMay 15, 2018
  2. git-submodule.sh: try harder to fetch a submoduleStefan Beller, May 15, 2018
  3. 2/3 merge-recursive: i18n submodule merge output and respect verbosityStefan Beller, May 15, 2018
  4. Junio C HamanoMay 16, 2018
  5. 3/3 Inform about fast-forwarding of submodules during mergeStefan Beller, May 15, 2018
  6. Elijah NewrenMay 16, 2018
  7. Junio C HamanoMay 16, 2018
  8. Junio C HamanoMay 16, 2018
  9. 0/1 merge-recursive: give notice when submodule commit gets fast-forwardedLeif Middelschulte, Jun 4, 2018
  10. 1/1 merge-recursive: give notice when submodule commit gets fast-forwardedLeif Middelschulte, Jun 4, 2018
  11. Elijah NewrenJun 7, 2018
  12. merge-submodule: reduce output verbosityLeif Middelschulte, Jun 11, 2018
  13. Junio C HamanoJun 11, 2018
  14. Leif MiddelschulteJun 11, 2018
  15. grep: handle corrupt index files earlyStefan Beller, May 15, 2018
  16. 1/3 submodule.c: move submodule merging to merge-recursive.cStefan Beller, May 15, 2018
  17. Stefan BellerMay 15, 2018
  18. Leif MiddelschulteMay 15, 2018
  19. Stefan BellerMay 15, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.