git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/2] t5516-fetch-push: fix broken &&-chain

From
SZEDER Gábor <szeder.dev@gmail.com>
Date
May 10, 2018, 14:01 UTC
Message-ID
<20180510140154.30381-2-szeder.dev@gmail.com>
In-Reply-To
<20180510140154.30381-1-szeder.dev@gmail.com>

b2dc968e60 (t5516: refactor oddball tests, 2008-11-07) accidentaly broke the &&-chain in the test 'push does not update local refs on failure', but since it was in a subshell, chain-lint couldn't notice it.

Signed-off-by: SZEDER Gábor <szeder.dev@gmail.com>
---
 t/t5516-fetch-push.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/t5516-fetch-push.sh b/t/t5516-fetch-push.sh
index 832b79ad40..3e8940eee5 100755
--- a/t/t5516-fetch-push.sh
+++ b/t/t5516-fetch-push.sh
@@ -612,7 +612,7 @@ test_expect_success 'push does not update local refs on failure' '
 	chmod +x testrepo/.git/hooks/pre-receive &&
 	(
 		cd child &&
-		git pull .. master
+		git pull .. master &&
 		test_must_fail git push &&
 		test $(git rev-parse master) != \
 			$(git rev-parse remotes/origin/master)
-- 
2.17.0.756.gcf614c5aff
Previous: SZEDER GáborNext: Junio C Hamano
Message 2 of 3 in “t5516-fetch-push: fix 'push with dry-run' test”
  1. 1/2 t5516-fetch-push: fix 'push with dry-run' testSZEDER Gábor, May 10, 2018
  2. 2/2 t5516-fetch-push: fix broken &&-chainSZEDER Gábor, May 10, 2018
  3. Junio C HamanoMay 11, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.