Re: Regression in patch add?
> does your test involve unusual file systems, funny characters in filenames, ..? You are on some sort of Linux, right?
I'm running macOS 10.13.4. I don't have any unusual file system setup, as far as I'm aware. The filename in my test case is simply `foo`.
I tried the steps you suggested: on git 2.17.0, saving the patch, editing it, and applying it, and it succeeded.
> should now show bar2 in the first hunk and bar1 in the second hunk, just like your edited test.patch.
That was the case, although I had to remove the `--check` flag from `git apply`.
> How comfortable are you with building Git from the sources?
I've never done it before, but I assume it's well documented, so I'm willing to give it a shot!
Happy to try any steps to debug this! Although I'm a bit surprised no-one else can reproduce it with the same version of Git, which makes it seem less likely this could be a bug, and more likely it's something in my setup.
Oliver Joseph Ash <oliverjash@gmail.com>