git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] replace-object.c: remove the_repository from prepare_replace_object

From
Jeff King <peff@peff.net>
Date
May 10, 2018, 11:56 UTC
Message-ID
<20180510115623.GA20632@sigill.intra.peff.net>
In-Reply-To
<xmqqtvrfizce.fsf@gitster-ct.c.googlers.com>
On Thu, May 10, 2018 at 07:23:13PM +0900, Junio C Hamano wrote:
Show 11 quoted lines
> This one was doing
> 
> 	ptr = xmalloc(sizeof(*another_ptr))
> 
> and it was OK because ptr and another_ptr happened to be of the same
> type.  I wonder if we are making it safer, or making it more obscure
> to seasoned C programmers, if we introduced a pair of helper macros,
> perhaps like these:
> 
> 	#define ALLOCATE(ptr) (ptr) = xmalloc(sizeof(*(ptr)))
> 	#define CALLOCATE(ptr,cnt) (ptr) = xcalloc((cnt), sizeof(*(ptr)))

I've often wondered that, too. It's the natural endgame of the ALLOC_ARRAY() road we've been going down.

-Peff
Previous: Junio C HamanoNext: Derrick Stolee
Message 4 of 8 in “object.c: free replace map in raw_object_store_clear”
  1. 1/2 object.c: free replace map in raw_object_store_clearStefan Beller, May 9, 2018
  2. 2/2 replace-object.c: remove the_repository from prepare_replace_objectStefan Beller, May 9, 2018
  3. Junio C HamanoMay 10, 2018
  4. Jeff KingMay 10, 2018
  5. Derrick StoleeMay 10, 2018
  6. Stefan BellerMay 10, 2018
  7. Junio C HamanoMay 10, 2018
  8. Stefan BellerMay 10, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.