git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/4] subtree: remove support for git version <1.7

From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date
Apr 30, 2018, 09:50 UTC
Message-ID
<20180430095044.28492-3-avarab@gmail.com>
In-Reply-To
<20180430095044.28492-1-avarab@gmail.com>

Now that git-subtree is in-tree there's no reason to be supporting older git Versions. This reverts & amends 448e71e263 ("Use 'git merge -Xsubtree' when git version >= 1.7.0.", 2010-05-07).

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
---
 git-subtree.sh | 19 ++++---------------
 1 file changed, 4 insertions(+), 15 deletions(-)
diff --git a/git-subtree.sh b/git-subtree.sh
index d3f39a862a..1b8cd53c7f 100755
--- a/git-subtree.sh
+++ b/git-subtree.sh
@@ -810,23 +810,12 @@ cmd_merge () {
 		rev="$new"
 	fi
 
-	version=$(git version)
-	if test "$version" \< "git version 1.7"
+	if test -n "$message"
 	then
-		if test -n "$message"
-		then
-			git merge -s subtree --message="$message" "$rev"
-		else
-			git merge -s subtree "$rev"
-		fi
+		git merge -Xsubtree="$prefix" \
+			--message="$message" "$rev"
 	else
-		if test -n "$message"
-		then
-			git merge -Xsubtree="$prefix" \
-				--message="$message" "$rev"
-		else
-			git merge -Xsubtree="$prefix" $rev
-		fi
+		git merge -Xsubtree="$prefix" $rev
 	fi
 }
 
-- 
2.17.0.290.gded63e768a
Previous: Ævar Arnfjörð BjarmasonNext: Ævar Arnfjörð Bjarmason
Message 2 of 15 in “subtree: move out of contrib”
  1. 0/4 subtree: move out of contribÆvar Arnfjörð Bjarmason, Apr 30, 2018
  2. 2/4 subtree: remove support for git version <1.7Ævar Arnfjörð Bjarmason, Apr 30, 2018
  3. 1/4 git-subtree: move from contrib/subtree/Ævar Arnfjörð Bjarmason, Apr 30, 2018
  4. 3/4 subtree: fix a test failure under GETTEXT_POISONÆvar Arnfjörð Bjarmason, Apr 30, 2018
  5. 4/4 i18n: translate the git-subtree commandÆvar Arnfjörð Bjarmason, Apr 30, 2018
  6. Philip OakleyApr 30, 2018
  7. Avery PennarunApr 30, 2018
  8. Stefan BellerApr 30, 2018
  9. Avery PennarunApr 30, 2018
  10. Stefan BellerApr 30, 2018
  11. Ævar Arnfjörð BjarmasonApr 30, 2018
  12. Avery PennarunApr 30, 2018
  13. Duy NguyenMay 1, 2018
  14. Johannes SchindelinMay 1, 2018
  15. Ævar Arnfjörð BjarmasonMay 1, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.