git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCHv3 8/9] packfile: add repository argument to cache_or_unpack_entry

From
Stefan Beller <sbeller@google.com>
Date
Apr 25, 2018, 18:21 UTC
Message-ID
<20180425182106.162972-9-sbeller@google.com>
In-Reply-To
<20180425182106.162972-1-sbeller@google.com>

Add a repository argument to allow the callers of cache_or_unpack_entry to be more specific about which repository to act on. This is a small mechanical change; it doesn't change the implementation to handle repositories other than the_repository yet.

As with the previous commits, use a macro to catch callers passing a repository other than the_repository at compile time.

Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Stefan Beller <sbeller@google.com>
---
 packfile.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/packfile.c b/packfile.c
index d5ac48ef18..8de87f904b 100644
--- a/packfile.c
+++ b/packfile.c
@@ -1272,7 +1272,8 @@ static void detach_delta_base_cache_entry(struct delta_base_cache_entry *ent)
 	free(ent);
 }
 
-static void *cache_or_unpack_entry(struct packed_git *p, off_t base_offset,
+#define cache_or_unpack_entry(r, p, bo, bs, t) cache_or_unpack_entry_##r(p, bo, bs, t)
+static void *cache_or_unpack_entry_the_repository(struct packed_git *p, off_t base_offset,
 	unsigned long *base_size, enum object_type *type)
 {
 	struct delta_base_cache_entry *ent;
@@ -1346,7 +1347,7 @@ int packed_object_info_the_repository(struct packed_git *p, off_t obj_offset,
 	 * a "real" type later if the caller is interested.
 	 */
 	if (oi->contentp) {
-		*oi->contentp = cache_or_unpack_entry(p, obj_offset, oi->sizep,
+		*oi->contentp = cache_or_unpack_entry(the_repository, p, obj_offset, oi->sizep,
 						      &type);
 		if (!*oi->contentp)
 			type = OBJ_BAD;
-- 
2.17.0.441.gb46fe60e1d-goog
Previous: Stefan BellerNext: Stefan Beller
Message 21 of 24 in “[PATCHv2 0/9] object store: oid_object_info is the next contender”
  1. Stefan BellerApr 24, 2018
  2. 1/9 cache.h: add repository argument to oid_object_info_extendedStefan Beller, Apr 24, 2018
  3. 2/9 cache.h: add repository argument to oid_object_infoStefan Beller, Apr 24, 2018
  4. 3/9 packfile: add repository argument to retry_bad_packed_offsetStefan Beller, Apr 24, 2018
  5. 4/9 packfile: add repository argument to packed_to_object_typeStefan Beller, Apr 24, 2018
  6. 5/9 packfile: add repository argument to packed_object_infoStefan Beller, Apr 24, 2018
  7. 9/9 cache.h: allow oid_object_info to handle arbitrary repositoriesStefan Beller, Apr 24, 2018
  8. Jonathan TanApr 24, 2018
  9. 8/9 packfile: add repository argument to cache_or_unpack_entryStefan Beller, Apr 24, 2018
  10. 7/9 packfile: add repository argument to unpack_entryStefan Beller, Apr 24, 2018
  11. 6/9 packfile: add repository argument to read_objectStefan Beller, Apr 24, 2018
  12. 9/9 cache.h: allow sha1_object_info to handle arbitrary repositoriesStefan Beller, Apr 24, 2018
  13. 0/9 object store: oid_object_info is the next contenderStefan Beller, Apr 25, 2018
  14. 1/9 cache.h: add repository argument to oid_object_info_extendedStefan Beller, Apr 25, 2018
  15. 3/9 packfile: add repository argument to retry_bad_packed_offsetStefan Beller, Apr 25, 2018
  16. 6/9 packfile: add repository argument to read_objectStefan Beller, Apr 25, 2018
  17. 9/9 cache.h: allow oid_object_info to handle arbitrary repositoriesStefan Beller, Apr 25, 2018
  18. 2/9 cache.h: add repository argument to oid_object_infoStefan Beller, Apr 25, 2018
  19. 5/9 packfile: add repository argument to packed_object_infoStefan Beller, Apr 25, 2018
  20. 4/9 packfile: add repository argument to packed_to_object_typeStefan Beller, Apr 25, 2018
  21. 8/9 packfile: add repository argument to cache_or_unpack_entryStefan Beller, Apr 25, 2018
  22. 7/9 packfile: add repository argument to unpack_entryStefan Beller, Apr 25, 2018
  23. Jonathan TanApr 25, 2018
  24. Brandon WilliamsApr 26, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.