Re: [PATCH 21/41] http: eliminate hard-coded constants

From: brian m. carlson <sandals@crustytoothpaste.net>
Date: Apr 25, 2018, 01:29 UTC
Message-ID: <20180425012949.GE245996@genre.crustytoothpaste.net>
In-Reply-To: <xmqqpo2o5fvw.fsf@gitster-ct.c.googlers.com>

On Wed, Apr 25, 2018 at 08:44:19AM +0900, Junio C Hamano wrote:

Show 20 quoted lines

> Martin Ågren <martin.agren@gmail.com> writes:
> 
> >>                 switch (data[i]) {
> >>                 case 'P':
> >>                         i++;
> >> -                       if (i + 52 <= buf.len &&
> >> +                       if (i + hexsz + 12 <= buf.len &&
> >>                             starts_with(data + i, " pack-") &&
> >> -                           starts_with(data + i + 46, ".pack\n")) {
> >> -                               get_sha1_hex(data + i + 6, sha1);
> >> -                               fetch_and_setup_pack_index(packs_head, sha1,
> >> +                           starts_with(data + i + hexsz + 6, ".pack\n")) {
> >> +                               get_sha1_hex(data + i + 6, hash);
> >> +                               fetch_and_setup_pack_index(packs_head, hash,
> >>                                                       base_url);
> >>                                 i += 51;
> >
> > s/51/hexsz + 11/ ?
> 
> Quite right.

Good point.  Will fix.

-- 
brian m. carlson: Houston, Texas, US
OpenPGP: https://keybase.io/bk2204