Re: [PATCH 2/9] cache.h: add repository argument to oid_object_info
On Mon, Apr 23, 2018 at 04:43:20PM -0700, Stefan Beller wrote:
Show 12 quoted lines
> Add a repository argument to allow the callers of oid_object_info
> to be more specific about which repository to handle. This is a small
> mechanical change; it doesn't change the implementation to handle
> repositories other than the_repository yet.
>
> In the expanded macro the identifier `the_repository` is not actually used,
> so the compiler does not catch if the repository.h header is not included
> at the call site. call sites needing that #include were identified by
> changing the macro to definition to
>
> #define sha1_object_info(r, sha1, size) \
> (r, sha1_object_info_##r(sha1, size)).
I think you may have wanted to write "oid_object_info" here.
--
brian m. carlson: Houston, Texas, US
OpenPGP: https://keybase.io/bk2204