git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] configure.ac: fix botched FREAD_READS_DIRECTORIES check

From
Eric Sunshine <sunshine@sunshineco.com>
Date
Apr 9, 2018, 08:50 UTC
Message-ID
<20180409085042.20215-1-sunshine@sunshineco.com>

3adf9fdecf (configure.ac: loosen FREAD_READS_DIRECTORIES test program, 2017-06-14) broke the test program for the FREAD_READS_DIRECTORIES check by making it syntactically invalid (a dangling ")") and by botching the type returned from 'main' (a FILE* rather than int). As a consequence, the test program won't even compile, thus the check fails unconditionally. Fix these problems.

Reported-by: Jonathan Primrose <jprimros@gmail.com>
Signed-off-by: Eric Sunshine <sunshine@sunshineco.com>
---

Problem report and discussion: https://public-inbox.org/git/82c91eac-9dc4-834b-4648-3c4ba45af80d@gmail.com/

 configure.ac | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure.ac b/configure.ac
index 7f8415140f..a30d947e2a 100644
--- a/configure.ac
+++ b/configure.ac
@@ -923,7 +923,7 @@ AC_RUN_IFELSE(
 	[AC_LANG_PROGRAM([AC_INCLUDES_DEFAULT],
 		[[
 		FILE *f = fopen(".", "r");
-		return f)]])],
+		return f != NULL;]])],
 	[ac_cv_fread_reads_directories=no],
 	[ac_cv_fread_reads_directories=yes])
 ])
-- 
2.17.0.484.g0c8726318c
Message 1 of 1 in “configure.ac: fix botched FREAD_READS_DIRECTORIES check”
  1. configure.ac: fix botched FREAD_READS_DIRECTORIES checkEric Sunshine, Apr 9, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.