Re: [PATCH] Fix condition for redirecting stderr

From: Todd Zullinger <tmz@pobox.com>
Date: Apr 9, 2018, 02:23 UTC
Message-ID: <20180409022303.GS29680@zaya.teonanacatl.net>
In-Reply-To: <20180403221307.29194-1-mail@lucaswerkmeister.de>

Lucas Werkmeister wrote:

Show 5 quoted lines

> Since the --log-destination option was added in 0c591cacb ("daemon: add
> --log-destination=(stderr|syslog|none)", 2018-02-04) with the explicit
> goal of allowing logging to stderr when running in inetd mode, we should
> not always redirect stderr to /dev/null in inetd mode, but rather only
> when stderr is not being used for logging.

Perhaps 's/^F/daemon: f/' on the subject? (Junio may well already have done so while queueing locally.)

The patch itself looks reasonable (to my relatively untrained eyes).

-- 
Todd
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Hardware:  the parts of a computer that can be kicked.
    -- Jeff Pesis