Re: What's cooking in git.git (Mar 2018, #06; Fri, 30)
- From
Jeff King <peff@peff.net>
- Date
- Apr 4, 2018, 20:49 UTC
- Message-ID
- <20180404204920.GA15402@sigill.intra.peff.net>
- In-Reply-To
- <87a7uow0jc.fsf@evledraar.gmail.com>
On Sat, Mar 31, 2018 at 08:41:11PM +0200, Ævar Arnfjörð Bjarmason wrote:
Show 13 quoted lines
> > [...] > > * jk/drop-ancient-curl (2017-08-09) 5 commits > > - http: #error on too-old curl > > - curl: remove ifdef'd code never used with curl >=7.19.4 > > - http: drop support for curl < 7.19.4 > > - http: drop support for curl < 7.16.0 > > - http: drop support for curl < 7.11.1 > > > > Some code in http.c that has bitrot is being removed. > > > > Expecting a reroll. > > This has been idle for a long time. Peff: What's left to be done for it?
It wasn't clear to me we actually wanted to do this. It got some complaints, and then somebody showed up to actually fix the compilation problems with the old versions.
It also isn't that much of a burden to carry the #ifdefs. The main question is whether we're doing a disservice to users, since those old setups likely aren't well tested.
Even if we do proceed, I'm not sure if we'd want the top #error patch, given the reports that distros will sometimes backport features.
-Peff