[PATCH 1/2] t5561: drop curl stderr redirects
- From
Jeff King <peff@peff.net>
- Date
- Apr 3, 2018, 14:01 UTC
- Message-ID
- <20180403140140.GA30376@sigill.intra.peff.net>
- In-Reply-To
- <20180403140055.GA29556@sigill.intra.peff.net>
For a normal test run, stderr is already redirected to /dev/null by the test suite. When used with "-v", suppressing stderr is actively harmful, as it may hide the reason for curl failing.
Reported-by: Jens Krüger <Jens.Krueger@frm2.tum.de> Signed-off-by: Jeff King <peff@peff.net> --- t/t5561-http-backend.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/t/t5561-http-backend.sh b/t/t5561-http-backend.sh index 90e0d6f0fe..6167563986 100755 --- a/t/t5561-http-backend.sh +++ b/t/t5561-http-backend.sh @@ -6,7 +6,7 @@ test_description='test git-http-backend' start_httpd GET() { - curl --include "$HTTPD_URL/$SMART/repo.git/$1" >out 2>/dev/null && + curl --include "$HTTPD_URL/$SMART/repo.git/$1" >out && tr '\015' Q <out | sed ' s/Q$// @@ -19,7 +19,7 @@ GET() { POST() { curl --include --data "$2" \ --header "Content-Type: application/x-$1-request" \ - "$HTTPD_URL/smart/repo.git/$1" >out 2>/dev/null && + "$HTTPD_URL/smart/repo.git/$1" >out && tr '\015' Q <out | sed ' s/Q$//
-- 2.17.0.686.g08b0810b04