Re: [PATCH] credential: cred helper fast exit can cause SIGPIPE, crash

From: Jeff King <peff@peff.net>
Date: Mar 29, 2018, 17:55 UTC
Message-ID: <20180329175501.GE31833@sigill.intra.peff.net>
In-Reply-To: <330BFBFA-6B9E-456D-A9B3-2D0EF5383A57@cisco.com>

On Thu, Mar 29, 2018 at 05:25:04PM +0000, Erik Brady -X (brady - ROBERT HALF INTERNATIONAL INC at Cisco) wrote:

Show 5 quoted lines

> OK, will retry on the comment.  I guess I misunderstood the guidelines
> a bit on the signoff as well (ie: non-optional), apologies.  Will
> resubmit via 'git send-email' after adjusting the comment and
> recommitting with the -s option.  First time for everything I suppose,
> doh.

The signoff (for our project) is all about the "yes, this contribution can go under the gpl". So that part is very non-optional. :)

Show 5 quoted lines

> As to your comment suggestion, appreciated, looks good.  I might
> reword the #1 item you have just a bit (I removed the host specific
> stuff since I think the race can occur regardless of host specific or
> not... but I might be missing something there?).  Anyhow, how about
> something like this:

Yeah, it can definitely occur regardless. It was just the plausible reason to have a handler which does not bother to look at the incoming data (since otherwise you are spewing your password to any host you connect to; maybe that's OK if you configure it only inside a specific repo and only fetch from one server).

Your update looks fine to me.

Thanks.

-Peff