Re: [PATCH 04/10] t1405: sort reflog entries in a hash-independent way

From: brian m. carlson <sandals@crustytoothpaste.net>
Date: Mar 26, 2018, 23:02 UTC
Message-ID: <20180326230241.GH74743@genre.crustytoothpaste.net>
In-Reply-To: <xmqqefk6bhw3.fsf@gitster-ct.c.googlers.com>

On Mon, Mar 26, 2018 at 03:18:20PM -0700, Junio C Hamano wrote:

Show 17 quoted lines

> "brian m. carlson" <sandals@crustytoothpaste.net> writes:
> 
> > The test enumerates reflog entries in an arbitrary order and then sorts
> > them.  For SHA-1, this produces results that happen to sort in
> > alphabetical order, but for other hash algorithms they sort differently.
> > Ensure we sort the reflog entries in a hash-independent way by sorting
> > on the ref name instead of the object ID.
> 
> Makes sense.
> 
> > Remove an assumption about the length of a hash by using cut with
> > the delimiter and field options instead of the character range
> > option.
> 
> I thought you used your truncated blake hash to develop and verify
> these changes, but I'd imagine that the "42" thing were hard to
> spot.

Yeah, I had to do those by hand, but it looks like I did miss one. I'll reroll with that change.

-- 
brian m. carlson / brian with sandals: Houston, Texas, US
https://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: https://keybase.io/bk2204