Re: [PATCH v3 00/36] object_id part 12

From: brian m. carlson <sandals@crustytoothpaste.net>
Date: Mar 15, 2018, 01:05 UTC
Message-ID: <20180315010538.GC330384@genre.crustytoothpaste.net>
In-Reply-To: <xmqqtvtizjq9.fsf@gitster-ct.c.googlers.com>

On Wed, Mar 14, 2018 at 09:48:30AM -0700, Junio C Hamano wrote:

Show 14 quoted lines

> As always, thanks for working on this.  
> 
> After this series, what jumps at me out of output from
> 
>     git grep -e '[^0-9A-Za-z_][24]0[^0-9A-Za-z_]' -- '*.[ch]' \
> 		':!*sha1*' ':!contrib/' ':!compat/'
> 
> are code that parses the incoming patch in apply.c (where the full
> blob object names used for binary patches are assumed to be in
> SHA-1), builtin/pack-objects.c (where it has to know the current
> file format of a packfile intimately) and diff.c (where it clips the
> length to which the blob object names on the "index" lines are
> abbreviated to).  Changing 40 in the last one to "the hex length of
> the currently deployed hash" should be relatively uncontroversial.

I have patches that hit several of these places, but not diff.c. I'll probably pick that piece up next.

By the way, thanks for a useful regex. It's a little bit different than what I've been using, but provides a nice overview.

-- 
brian m. carlson / brian with sandals: Houston, Texas, US
https://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: https://keybase.io/bk2204