Re: [RFC] Contributing to Git (on Windows)

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Mar 5, 2018, 18:26 UTC
Message-ID: <20180305182658.GC28067@aiede.svl.corp.google.com>
In-Reply-To: <nycvar.QRO.7.76.6.1803051711210.20700@ZVAVAG-6OXH6DA.rhebcr.pbec.zvpebfbsg.pbz>

Hi again,

Back on topic, some quick clarifications to tie up loose ends.

Also I want to thank you for continuing to push the project to work better (especially to work better for newcomers). We don't seem to have a habit of saying often enough how important that goal is. Of course we'll disagree from time to time in minor ways about particular aspects of how to change the development workflow, but the progress you've already made (e.g. via tools like SubmitGit) is a huge deal.

[...] Johannes Schindelin wrote:

> On Sat, 3 Mar 2018, Jonathan Nieder wrote:

Show 5 quoted lines

>>  1. Approximately 1/2 of the differences you describe apply to Mac as
>>     well as Windows.
>
> No. The executable bit, the native line endings, most of the issues I
> listed do not catch macOS-based developers off guard.

Yeah, my wording was really sloppy.

I meant that one of the differences you described half-applies to Mac and the rest don't apply to Mac. I should have proofread.

[...]

> Stolee agreed in the PR to mention alternatives to Hyper-V, such as
> VirtualBox, which would help macOS-based developers here.

I have no opinion about that (maybe it will make the text too long and overwhelming, or maybe it will help people on balance).

[...]

> The Google gang (you & Junio included) uses Linux. Peff uses Linux. From
> what I can see Duy, Eric and Jake use Linux. That covers already the most
> active reviewers right there.

We are not as uniform as it may seem. The Google gang all uses Linux on workstations but some use Mac laptops as well. We deal with user reports all the time from all three popular platforms.

IIRC then Junio has a test setup that tests on Linux, FreeBSD, and some other platforms. IIRC Microsoft provides a way to run a Windows VM for development purposes that he could use for testing in the same way as he tests on FreeBSD if there are clear enough instructions for doing it (hint, hint). :)

Of course it's even better if there is some public shared build/test dashboard that we can all work together to at least keep green.

[...]

> So where is that formatter call that fixes your code?

There's "make style", and people still continue to work on improving its configuration (thanks!).

[...]

> However, VSTS is free for teams up to five, meaning that any developer can
> register a project, and once I manage to get build definitions in shape, I
> can make them public and anybody can test their code on the major three
> platforms, in their personal VSTS account.

Thanks. That sounds potentially useful. (Though a shared dashboard that we all keep green might be even more so.)

[...]

> So everything is a legal text.

Yeah. In this context I should have instead said something like "lawyer-reviewed text".

[...]

> Put another way: I indulged in veering off on a tangent. You know, like we
> do for fun here ;-)

Feel free to call me on it when my tangents are hurting, or when they're helping for that matter. That way I have training data to improve my model of how to make a good tangent. :)

Sincerely, Jonathan