Re: Bug report: "Use of uninitialized value $_ in print"

From: Jeff King <peff@peff.net>
Date: Mar 3, 2018, 05:57 UTC
Message-ID: <20180303055715.GH27689@sigill.intra.peff.net>
In-Reply-To: <xmqqo9k6csan.fsf@gitster-ct.c.googlers.com>

On Fri, Mar 02, 2018 at 09:15:44AM -0800, Junio C Hamano wrote:

Show 9 quoted lines

> Jeff King <peff@peff.net> writes:
> 
> > That's probably a reasonable sanity check, but I think we need to abort
> > and not just have a too-small DISPLAY array. Because later code like the
> > hunk-splitting is going to assume that there's a 1:1 line
> > correspondence. We definitely don't want to end up in a situation where
> > we show one thing but apply another.
> 
> Yes, agreed completely.

Let's add this sanity check while we're thinking about it. Here's a series.

  [1/2]: t3701: add a test for interactive.diffFilter
  [2/2]: add--interactive: detect bogus diffFilter output

 git-add--interactive.perl  |  8 ++++++++
 t/t3701-add-interactive.sh | 20 ++++++++++++++++++++
 2 files changed, 28 insertions(+)

-Peff