Re: [PATCH 1/2] ref-filter: mark a file-local symbol as static

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Mar 2, 2018, 03:59 UTC
Message-ID: <20180302035904.GA238112@aiede.svl.corp.google.com>
In-Reply-To: <1d28d866-535c-6d37-4cb9-5decedab3acb@ramsayjones.plus.com>

Hi,

Ramsay Jones wrote:

> Commit fcfba37337 ('ref-filter: make "--contains <id>" less chatty if
> <id> is invalid', 2018-02-23) added the add_str_to_commit_list()
> function, which causes sparse to issue a "... not declared. Should it
> be static?" warning for that symbol.

Thanks for catching it!

> In order to suppress the warning, mark that function as static.

Isn't this closer to

	Indeed, the function is only used in this one compilation
	unit. Mark it static.

? In other words, sparse's warning is accurate, and this is not about trying to quiet a false positive but about addressing a true positive.

> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
> ---
>  ref-filter.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Thanks, Jonathan