git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 07/36] ref-filter: convert grab_objectname to struct object_id

From
brian m. carlson <sandals@crustytoothpaste.net>
Date
Feb 25, 2018, 21:11 UTC
Message-ID
<20180225211212.477570-8-sandals@crustytoothpaste.net>
In-Reply-To
<20180225211212.477570-1-sandals@crustytoothpaste.net>
This is necessary in order to convert find_unique_abbrev.
Signed-off-by: brian m. carlson <sandals@crustytoothpaste.net>
---
 ref-filter.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/ref-filter.c b/ref-filter.c
index f9e25aea7a..9cbd92611c 100644
--- a/ref-filter.c
+++ b/ref-filter.c
@@ -737,18 +737,18 @@ static void *get_obj(const struct object_id *oid, struct object **obj, unsigned
 	return buf;
 }
 
-static int grab_objectname(const char *name, const unsigned char *sha1,
+static int grab_objectname(const char *name, const struct object_id *oid,
 			   struct atom_value *v, struct used_atom *atom)
 {
 	if (starts_with(name, "objectname")) {
 		if (atom->u.objectname.option == O_SHORT) {
-			v->s = xstrdup(find_unique_abbrev(sha1, DEFAULT_ABBREV));
+			v->s = xstrdup(find_unique_abbrev(oid->hash, DEFAULT_ABBREV));
 			return 1;
 		} else if (atom->u.objectname.option == O_FULL) {
-			v->s = xstrdup(sha1_to_hex(sha1));
+			v->s = xstrdup(oid_to_hex(oid));
 			return 1;
 		} else if (atom->u.objectname.option == O_LENGTH) {
-			v->s = xstrdup(find_unique_abbrev(sha1, atom->u.objectname.length));
+			v->s = xstrdup(find_unique_abbrev(oid->hash, atom->u.objectname.length));
 			return 1;
 		} else
 			die("BUG: unknown %%(objectname) option");
@@ -775,7 +775,7 @@ static void grab_common_values(struct atom_value *val, int deref, struct object
 			v->s = xstrfmt("%lu", sz);
 		}
 		else if (deref)
-			grab_objectname(name, obj->oid.hash, v, &used_atom[i]);
+			grab_objectname(name, &obj->oid, v, &used_atom[i]);
 	}
 }
 
@@ -1439,7 +1439,7 @@ static void populate_value(struct ref_array_item *ref)
 				v->s = xstrdup(buf + 1);
 			}
 			continue;
-		} else if (!deref && grab_objectname(name, ref->objectname.hash, v, atom)) {
+		} else if (!deref && grab_objectname(name, &ref->objectname, v, atom)) {
 			continue;
 		} else if (!strcmp(name, "HEAD")) {
 			if (atom->u.head && !strcmp(ref->refname, atom->u.head))
Previous: brian m. carlson
Message 42 of 42 in “object_id part 12”
  1. 00/36 object_id part 12brian m. carlson, Feb 25, 2018
  2. 01/36 bulk-checkin: convert index_bulk_checkin to struct object_idbrian m. carlson, Feb 25, 2018
  3. 03/36 cache-tree: convert write_*_as_tree to object_idbrian m. carlson, Feb 25, 2018
  4. 04/36 cache-tree: convert remnants to struct object_idbrian m. carlson, Feb 25, 2018
  5. Duy NguyenFeb 26, 2018
  6. 02/36 builtin/write-tree: convert to struct object_idbrian m. carlson, Feb 25, 2018
  7. 06/36 tree: convert read_tree_recursive to struct object_idbrian m. carlson, Feb 25, 2018
  8. 12/36 send-pack: convert remaining functions to struct object_idbrian m. carlson, Feb 25, 2018
  9. 13/36 replace_object: convert struct replace_object to object_idbrian m. carlson, Feb 25, 2018
  10. 14/36 builtin/mktag: convert to struct object_idbrian m. carlson, Feb 25, 2018
  11. 15/36 archive: convert write_archive_entry_fn_t to object_idbrian m. carlson, Feb 25, 2018
  12. 17/36 builtin/index-pack: convert struct ref_delta_entry to object_idbrian m. carlson, Feb 25, 2018
  13. 18/36 sha1_file: convert read_loose_object to use struct object_idbrian m. carlson, Feb 25, 2018
  14. 23/36 sha1_file: convert retry_bad_packed_offset to struct object_idbrian m. carlson, Feb 25, 2018
  15. 30/36 streaming: convert istream internals to struct object_idbrian m. carlson, Feb 25, 2018
  16. 22/36 sha1_file: convert assert_sha1_type to object_idbrian m. carlson, Feb 25, 2018
  17. 29/36 tree-walk: convert get_tree_entry_follow_symlinks internals to object_idbrian m. carlson, Feb 25, 2018
  18. 32/36 sha1_file: convert read_object_with_reference to object_idbrian m. carlson, Feb 25, 2018
  19. 35/36 sha1_file: introduce a constant for max header lengthbrian m. carlson, Feb 25, 2018
  20. 34/36 Convert lookup_replace_object to struct object_idbrian m. carlson, Feb 25, 2018
  21. Duy NguyenFeb 26, 2018
  22. 33/36 sha1_file: convert read_sha1_file to struct object_idbrian m. carlson, Feb 25, 2018
  23. 36/36 convert: convert to struct object_idbrian m. carlson, Feb 25, 2018
  24. 31/36 tree-walk: convert tree entry functions to object_idbrian m. carlson, Feb 25, 2018
  25. 28/36 builtin/notes: convert static functions to object_idbrian m. carlson, Feb 25, 2018
  26. 27/36 builtin/fmt-merge-msg: convert remaining code to object_idbrian m. carlson, Feb 25, 2018
  27. 26/36 sha1_file: convert sha1_object_info* to object_idbrian m. carlson, Feb 25, 2018
  28. 25/36 Convert remaining callers of sha1_object_info_extended to object_idbrian m. carlson, Feb 25, 2018
  29. 24/36 packfile: convert unpack_entry to struct object_idbrian m. carlson, Feb 25, 2018
  30. 21/36 builtin/mktree: convert to struct object_idbrian m. carlson, Feb 25, 2018
  31. 11/36 http-walker: convert struct object_request to use struct object_idbrian m. carlson, Feb 25, 2018
  32. 05/36 resolve-undo: convert struct resolve_undo_info to object_idbrian m. carlson, Feb 25, 2018
  33. Duy NguyenFeb 26, 2018
  34. brian m. carlsonFeb 27, 2018
  35. Duy NguyenFeb 28, 2018
  36. 20/36 streaming: convert open_istream to use struct object_idbrian m. carlson, Feb 25, 2018
  37. 19/36 sha1_file: convert check_sha1_signature to struct object_idbrian m. carlson, Feb 25, 2018
  38. 16/36 archive: convert sha1_file_to_archive to struct object_idbrian m. carlson, Feb 25, 2018
  39. 10/36 Convert find_unique_abbrev* to struct object_idbrian m. carlson, Feb 25, 2018
  40. 09/36 wt-status: convert struct wt_status_state to object_idbrian m. carlson, Feb 25, 2018
  41. 08/36 strbuf: convert strbuf_add_unique_abbrev to use struct object_idbrian m. carlson, Feb 25, 2018
  42. 07/36 ref-filter: convert grab_objectname to struct object_idbrian m. carlson, Feb 25, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.