[PATCH v2 0/2] two small grep patches
- From
Rasmus Villemoes <rv@rasmusvillemoes.dk>
- Date
- Feb 23, 2018, 14:47 UTC
- Message-ID
- <20180223144757.31875-1-rv@rasmusvillemoes.dk>
- In-Reply-To
- <20180215215615.21208-1-rv@rasmusvillemoes.dk>
Changes in v2:
- Drop patch 3 with dubious gain/complexity ratio - Add comments regarding ownership of grep_source
I was a little torn between copy-pasting the comment or just saying "see above" in the second case. I think a memset would be confusing, at least unless one extends the comment to explain why one then does the memset despite the first half of the comment.
Rasmus Villemoes (2): grep: move grep_source_init outside critical section grep: simplify grep_oid and grep_file
builtin/grep.c | 33 ++++++++++++++++++++------------- 1 file changed, 20 insertions(+), 13 deletions(-)
-- 2.15.1