Re: [PATCH v7 0/7] convert: add support for different encodings

From: Jeff King <peff@peff.net>
Date: Feb 22, 2018, 20:12 UTC
Message-ID: <20180222201248.GA23561@sigill.intra.peff.net>
In-Reply-To: <19EDC192-0D83-4762-AC6A-81F7D693475A@gmail.com>

On Thu, Feb 22, 2018 at 09:00:45PM +0100, Lars Schneider wrote:

Show 11 quoted lines

> > If it was only about a diff of UTF-16 files, I may suggest a patch.
> > I simply copy-paste it here for review, if someone thinks that it may
> > be useful, I can send it as a real patch/RFC.
> 
> That's a nice idea but I see two potential problems:
> 
> (1) Git hosting services (GitLab, BitBucket, GitHub, ...) would still
>     show these files as binary. That's a huge problem for my users as
>     they interact more with these services than the Git command line.
>     That's the main reason why I implemented the "UTF-8 as canonical
>     form" approach in my series.

I can't speak for the other services, but I can tell you that GitHub would be pretty eager to enable such a feature if it existed.

I suspect most services providing human-readable diffs would want to do the same. Though there are still cases where you'd see a binary patch (e.g., format-patch in emails, or GitHub's .patch endpoint, since those are meant to be applied and must contain the "real" data).

-Peff