git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: What's cooking in git.git (Feb 2018, #03; Wed, 21)

From
BWBrandon Williams <bmwill@google.com>
Date
Feb 22, 2018, 00:56 UTC
Message-ID
<20180222005640.GI127348@google.com>
In-Reply-To
<xmqq1shdyidz.fsf@gitster-ct.c.googlers.com>
On 02/21, Junio C Hamano wrote:
Show 47 quoted lines
> * bw/c-plus-plus (2018-02-14) 38 commits
>  - fixup! diff: rename 'this' variables
>  - replace: rename 'new' variables
>  - trailer: rename 'template' variables
>  - tempfile: rename 'template' variables
>  - wrapper: rename 'template' variables
>  - environment: rename 'namespace' variables
>  - diff: rename 'template' variables
>  - environment: rename 'template' variables
>  - init-db: rename 'template' variables
>  - unpack-trees: rename 'new' variables
>  - trailer: rename 'new' variables
>  - submodule: rename 'new' variables
>  - split-index: rename 'new' variables
>  - remote: rename 'new' variables
>  - ref-filter: rename 'new' variables
>  - read-cache: rename 'new' variables
>  - line-log: rename 'new' variables
>  - imap-send: rename 'new' variables
>  - http: rename 'new' variables
>  - entry: rename 'new' variables
>  - diffcore-delta: rename 'new' variables
>  - diff: rename 'new' variables
>  - diff-lib: rename 'new' variable
>  - commit: rename 'new' variables
>  - combine-diff: rename 'new' variables
>  - remote: rename 'new' variables
>  - reflog: rename 'new' variables
>  - pack-redundant: rename 'new' variables
>  - help: rename 'new' variables
>  - checkout: rename 'new' variables
>  - apply: rename 'new' variables
>  - apply: rename 'try' variables
>  - diff: rename 'this' variables
>  - rev-parse: rename 'this' variable
>  - pack-objects: rename 'this' variables
>  - blame: rename 'this' variables
>  - object: rename function 'typename' to 'type_name'
>  - object_info: change member name from 'typename' to 'type_name'
> 
>  Avoid using identifiers that clash with C++ keywords.  Even though
>  it is not a goal to compile Git with C++ compilers, changes like
>  this help use of code analysis tools that targets C++ on our
>  codebase.
> 
>  Is the 'fixup!' cleanly squashable to the problematic one, or does
>  this series require another reroll to get it in a good enough shape?

Yeah the fixup patch looks good to me. I don't think there was anything else that needed attention so it should be in good shape with the fixup patch.

-- 
Brandon Williams
Previous: Junio C HamanoNext: Junio C Hamano
Message 2 of 13 in “What's cooking in git.git (Feb 2018, #03; Wed, 21)”
  1. Junio C HamanoFeb 22, 2018
  2. Brandon WilliamsFeb 22, 2018
  3. Junio C HamanoFeb 22, 2018
  4. Johannes SchindelinFeb 23, 2018
  5. Junio C HamanoFeb 23, 2018
  6. Johannes SchindelinFeb 26, 2018
  7. Junio C HamanoFeb 27, 2018
  8. Phillip WoodFeb 23, 2018
  9. Elijah NewrenFeb 23, 2018
  10. Junio C HamanoFeb 27, 2018
  11. Duy NguyenFeb 26, 2018
  12. Eric SunshineFeb 26, 2018
  13. Jeff HostetlerFeb 27, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.