Re: Fetch-hooks

From: Jeff King <peff@peff.net>
Date: Feb 14, 2018, 01:35 UTC
Message-ID: <20180214013520.GA25188@sigill.intra.peff.net>
In-Reply-To: <5abf8565-1aa1-c101-83a7-90781682bc7a@gaspard.io>

On Sat, Feb 10, 2018 at 07:36:47PM +0100, Leo Gaspard wrote:

Show 8 quoted lines

> Hmm... would this also drown the remote.<name>.fetch map? Also, I think
> this behavior could be emulated with fetch and fetchTagsTo, and it would
> look like:
> [remote "my-remote"]
>     fetch = +refs/heads/*:refs/remotes/my-remote/heads/*
>     fetchTagsTo = refs/remotes/my-remote/tags/*
> The remaining issue being to teach the lookup side to look for tags in
> all the remote-tag namespaces (and the fact it's a breaking change).

Right, I think fetching into the right spots is the easy part. Designing the new lookup rules is the tricky part.

If you're really interested in the gory details, here's a very old discussion on it:

  https://public-inbox.org/git/AANLkTi=yFwOAQMHhvLsB1_xmYOE9HHP2YB4H4TQzwwc8@mail.gmail.com/

I think there may have been some more concrete proposals after that, but that's what I was able to dig up quickly.

Show 7 quoted lines

> That said, actually I just noticed an issue in the “add a
> remote.<name>.fetch option to fetch to refs/quarantine then have the
> post-fetch hook do the work”: it means if I run `git pull`, then:
>  1. The remote references will be pulled to refs/quarantine/...
>  2. The post-fetch hook will copy the accepted ones to refs/remotes/...
>  3. The `git merge FETCH_HEAD` called by pull will merge FETCH_HEAD into
> local branches... and so merge from refs/quarantine.

Good point. You can't munge FETCH_HEAD by playing with refspecs.

I am starting to come around to the idea that "pre-fetch" might be the best way to do what you want. Not to rewrite refs, but perhaps to simply reject them. In the same way that we allow pre-receive to reject pushed refs (both are, after all, the final check on admitting new history into the repository, just in opposite directions).

Show 5 quoted lines

> So, when thinking about it, I'm back to thinking the proper hook
> interface should be the one of the tweak-fetch hook, but its
> implementation should make it not go crazy on remote servers. And so
> that the implementation should do all this refs/quarantine wizardry
> inside git itself.

So does anybody actually want to be able to adjust the refs as they pass through? It really sounds like you just want to be able to reject or not reject the fetch. And that rejecting would be the uncommon case, so it's OK to just abort the whole operation and expect the user to figure it out.

-Peff