Re: [PATCH v2 0/2] Refactor hash search with fanout table

From: Jonathan Tan <jonathantanmy@google.com>
Date: Feb 13, 2018, 20:15 UTC
Message-ID: <20180213121534.1c7b42109d40a9c41d0e8f0a@google.com>
In-Reply-To: <xmqqvaf0psrn.fsf@gitster-ct.c.googlers.com>

On Tue, 13 Feb 2018 11:57:16 -0800 Junio C Hamano <gitster@pobox.com> wrote:

Show 17 quoted lines

> Jonathan Tan <jonathantanmy@google.com> writes:
> 
> > Updates from v1:
> >  - use uint32_t so that we can operate on packfiles of up to 4G objects
> >    (this also means that I had to change the signature of the function)
> >  - don't hide types
> >
> > Derrick: you'll need to slightly change your patch to use the new API.
> > As for find_abbrev_len_for_pack(), that's a good idea - I didn't do it
> > in this set but it definitely should be done.
> >
> > Jonathan Tan (2):
> >   packfile: remove GIT_DEBUG_LOOKUP log statements
> >   packfile: refactor hash search with fanout table
> 
> Hmm, is this meant to replace the topic that was merged to 'next'
> last week?

Yes - René pointed out [1] that V1 of my patch series (which you merged to 'next') does not handle packfiles of more than 2G pack entries, so I sent out a new version. Yes, this replaces jt/binsearch-with-fanout. Sorry for not being clearer.

[1] https://public-inbox.org/git/cfbde137-dbac-8796-f49f-2a543303d33a@web.de/