[PATCH] t6300-for-each-ref: fix "more than one quoting style" tests
- From
SZEDER Gábor <szeder.dev@gmail.com>
- Date
- Feb 13, 2018, 00:36 UTC
- Message-ID
- <20180213003601.7396-1-szeder.dev@gmail.com>
'git for-each-ref' should error out when invoked with more than one quoting style options. The tests checking this have two issues:
- They run 'git for-each-ref' upstream of a pipe, hiding its exit
code, thus don't actually checking that 'git for-each-ref' exits
with error code.- They check the error message in a rather roundabout way.
Ensure that 'git for-each-ref' exits with an error code using the 'test_must_fail' helper function, and check its error message by grepping its saved standard error.
Signed-off-by: SZEDER Gábor <szeder.dev@gmail.com> ---
Those tests were like this since ancient times, c9ecf4f12a (for-each-ref: Fix quoting style constants., 2007-12-06).
t/t6300-for-each-ref.sh | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/t/t6300-for-each-ref.sh b/t/t6300-for-each-ref.sh index c128dfc579..295d1475bd 100755 --- a/t/t6300-for-each-ref.sh +++ b/t/t6300-for-each-ref.sh @@ -373,11 +373,8 @@ test_expect_success 'Quoting style: tcl' ' for i in "--perl --shell" "-s --python" "--python --tcl" "--tcl --perl"; do test_expect_success "more than one quoting style: $i" " - git for-each-ref $i 2>&1 | (read line && - case \$line in - \"error: more than one quoting style\"*) : happy;; - *) false - esac) + test_must_fail git for-each-ref $i 2>err && + grep '^error: more than one quoting style' err " done
-- 2.16.1.181.g4b60b0bfb6