git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[RFC PATCH 0/3] Make fsck check other worktree HEADs

From
Elijah Newren <newren@gmail.com>
Date
Feb 9, 2018, 23:13 UTC
Message-ID
<20180209231330.4457-1-newren@gmail.com>
This patchset adds checking of other worktree HEADs to fsck.

The reason I've marked this RFC is that I'm worried my incidental reliance on "worktrees/$WORKTREE/HEAD" resolving as a ref (in patch 3) might raise some flags for others. In particular, in [1] Peff said that this refname resolves right now mostly by accident and will probably stop working in the future. However, I feel that since fsck checks the storage format as well as contents, it seems natural that a change of storage model would result in the fsck code changing and thus that I'm not locking in any particular ref format long term with these changes. But I want to flag this issue for discussion.

[1] https://public-inbox.org/git/20180207181706.GA4227@sigill.intra.peff.net/
Elijah Newren (3):
  fsck: Move fsck_head_link() to get_default_heads() to avoid some
    globals
  t1450-fsck: Add tests for HEAD of other worktrees
  fsck: Check HEAD of other worktrees as well
 builtin/fsck.c  | 73 ++++++++++++++++++++++++++++++++++++++++++++-------------
 t/t1450-fsck.sh | 27 +++++++++++++++++++++
 2 files changed, 84 insertions(+), 16 deletions(-)
-- 
2.16.1.75.gc01c8fdd7d
Next: Elijah Newren
Message 1 of 7 in “Make fsck check other worktree HEADs”
  1. 0/3 Make fsck check other worktree HEADsElijah Newren, Feb 9, 2018
  2. 3/3 fsck: Check HEAD of other worktrees as wellElijah Newren, Feb 9, 2018
  3. Duy NguyenFeb 10, 2018
  4. Jeff KingFeb 10, 2018
  5. Junio C HamanoFeb 10, 2018
  6. 1/3 fsck: Move fsck_head_link() to get_default_heads() to avoid some globalsElijah Newren, Feb 9, 2018
  7. 2/3 t1450-fsck: Add tests for HEAD of other worktreesElijah Newren, Feb 9, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.