git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] name-hash: properly fold directory names in adjust_dirname_case()

From
Torsten Bögershausen <tboegi@web.de>
Date
Feb 9, 2018, 05:43 UTC
Message-ID
<20180209054331.GA8337@tor.lan>
In-Reply-To
<20180208192333.7436-1-benpeart@microsoft.com>
On Thu, Feb 08, 2018 at 02:23:33PM -0500, Ben Peart wrote:
[]
Show 6 quoted lines
> -
> +test_expect_success CASE_INSENSITIVE_FS 'add directory (with different case)' '
> +	git reset --hard initial &&
> +	mkdir -p dir1/dir2 &&
> +	echo > dir1/dir2/a &&
> +	echo > dir1/dir2/b &&
Thanks for working on this-
One and a half style nits:
The ">" should be close to the file name:
	echo >dir1/dir2/a &&
But then we don't even look into the file, so that the "\" produced by echo is not needed.
A simple 
	>dir1/dir2/a &&
is all that is needed.
Previous: Ben Peart
Message 8 of 8 in “name-hash: properly fold directory names in adjust_dirname_case()”
  1. name-hash: properly fold directory names in adjust_dirname_case()Ben Peart, Feb 8, 2018
  2. David TurnerFeb 8, 2018
  3. Torsten BögershausenFeb 8, 2018
  4. Ben PeartFeb 8, 2018
  5. Junio C HamanoFeb 8, 2018
  6. Junio C HamanoFeb 8, 2018
  7. name-hash: properly fold directory names in adjust_dirname_case()Ben Peart, Feb 8, 2018
  8. Torsten BögershausenFeb 9, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.