git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] always check for NULL return from packet_read_line()

From
Jeff King <peff@peff.net>
Date
Feb 8, 2018, 18:58 UTC
Message-ID
<20180208185842.GA1814@sigill.intra.peff.net>
In-Reply-To
<1518115670-2646-3-git-send-email-jon@jonsimons.org>
On Thu, Feb 08, 2018 at 01:47:50PM -0500, Jon Simons wrote:
Show 6 quoted lines
> The packet_read_line() function will die if it sees any
> protocol or socket errors. But it will return NULL for a
> flush packet; some callers which are not expecting this may
> dereference NULL if they get an unexpected flush. This would
> involve the other side breaking protocol, but we should
> flag the error rather than segfault.

As one might guess from the dual authorship on this series, Jon and I discussed these off list. So this one is

  Reviewed-by: Jeff King <peff@peff.net>
And the other one, too, but I'm not sure that carries any weight. :)
-Peff
Previous: Jon Simons
Message 4 of 4 in “Fix NULL checks for some packet_read_line call sites”
  1. 0/2 Fix NULL checks for some packet_read_line call sitesJon Simons, Feb 8, 2018
  2. 1/2 correct error messages for NULL packet_read_line()Jon Simons, Feb 8, 2018
  3. 2/2 always check for NULL return from packet_read_line()Jon Simons, Feb 8, 2018
  4. Jeff KingFeb 8, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.