Re: [PATCH v1] dir.c: don't flag the index as dirty for changes to the untracked cache

From: Jeff King <peff@peff.net>
Date: Feb 8, 2018, 10:33 UTC
Message-ID: <20180208103356.GA30524@sigill.intra.peff.net>
In-Reply-To: <20180205195619.31064-1-benpeart@microsoft.com>

On Mon, Feb 05, 2018 at 02:56:19PM -0500, Ben Peart wrote:

Show 10 quoted lines

> diff --git a/dir.c b/dir.c
> index 7c4b45e30e..da93374f0c 100644
> --- a/dir.c
> +++ b/dir.c
> @@ -2297,7 +2297,8 @@ int read_directory(struct dir_struct *dir, struct index_state *istate,
>  				 dir->untracked->gitignore_invalidated,
>  				 dir->untracked->dir_invalidated,
>  				 dir->untracked->dir_opened);
> -		if (dir->untracked == istate->untracked &&
> +		if (getenv("GIT_TEST_UNTRACKED_CACHE") &&

A minor nit, but please use something like:

  if (git_env_bool("GIT_TEST_UNTRACKED_CACHE", 0) && ...

so that:

  GIT_TEST_UNTRACKED_CACHE=false

does what one might expect, and not the opposite.

Two other thoughts:

  - it may be worth memo-izing it with a static variable to avoid
    repeatedly calling the possibly-slow getenv()

  - I agree with the sentiment elsewhere that something like
    GIT_FORCE_UNTRACKED_CACHE is probably a better name

(The idea itself seems sound to me, but it's not really my area).

-Peff