git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] docs/interpret-trailers: fix agreement error

From
JTJonathan Tan <jonathantanmy@google.com>
Date
Feb 8, 2018, 18:13 UTC
Message-ID
<20180208101358.af4ecca9865dca4f04431bce@google.com>
In-Reply-To
<20180208025614.872885-1-sandals@crustytoothpaste.net>

On Thu, 8 Feb 2018 02:56:14 +0000 "brian m. carlson" <sandals@crustytoothpaste.net> wrote:

Show 8 quoted lines
>  Existing trailers are extracted from the input message by looking for
> -a group of one or more lines that (i) are all trailers, or (ii) contains at
> -least one Git-generated or user-configured trailer and consists of at
> +a group of one or more lines that (i) are all trailers, or (ii) contain at
> +least one Git-generated or user-configured trailer and consist of at
>  least 25% trailers.
>  The group must be preceded by one or more empty (or whitespace-only) lines.
>  The group must either be at the end of the message or be the last

Ah, good catch. Maybe "a group of one or more lines that (i) consists of all trailers, or (ii) contains ..."?

I'm also OK with the patch as-is.
Previous: brian m. carlsonNext: Junio C Hamano
Message 2 of 6 in “docs/interpret-trailers: fix agreement error”
  1. docs/interpret-trailers: fix agreement errorbrian m. carlson, Feb 8, 2018
  2. Jonathan TanFeb 8, 2018
  3. Junio C HamanoFeb 8, 2018
  4. brian m. carlsonFeb 10, 2018
  5. docs/interpret-trailers: fix agreement errorbrian m. carlson, Feb 13, 2018
  6. Jonathan TanFeb 13, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.