git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v3 1/2] format-patch: keep cover-letter diffstat wrapped in 72 columns

From
Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Date
Feb 1, 2018, 12:47 UTC
Message-ID
<20180201124750.15032-2-pclouds@gmail.com>
In-Reply-To
<20180201124750.15032-1-pclouds@gmail.com>

We already wrap shortlog around 72 columns in cover letters. Do the same for diffstat (also in cover letters).

Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
---
 builtin/log.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/builtin/log.c b/builtin/log.c
index 46b4ca13e5..96af897403 100644
--- a/builtin/log.c
+++ b/builtin/log.c
@@ -29,6 +29,8 @@
 #include "gpg-interface.h"
 #include "progress.h"
 
+#define MAIL_DEFAULT_WRAP 72
+
 /* Set a default date-time format for git log ("log.date" config variable) */
 static const char *default_date_mode = NULL;
 
@@ -1044,7 +1046,7 @@ static void make_cover_letter(struct rev_info *rev, int use_stdout,
 
 	shortlog_init(&log);
 	log.wrap_lines = 1;
-	log.wrap = 72;
+	log.wrap = MAIL_DEFAULT_WRAP;
 	log.in1 = 2;
 	log.in2 = 4;
 	log.file = rev->diffopt.file;
@@ -1061,6 +1063,7 @@ static void make_cover_letter(struct rev_info *rev, int use_stdout,
 
 	memcpy(&opts, &rev->diffopt, sizeof(opts));
 	opts.output_format = DIFF_FORMAT_SUMMARY | DIFF_FORMAT_DIFFSTAT;
+	opts.stat_width = MAIL_DEFAULT_WRAP;
 
 	diff_setup_done(&opts);
 
-- 
2.16.1.205.g271f633410
Previous: Nguyễn Thái Ngọc DuyNext: Nguyễn Thái Ngọc Duy
Message 15 of 17 in “format-patch: set diffstat width to 70 instead of default 80”
  1. format-patch: set diffstat width to 70 instead of default 80Nguyễn Thái Ngọc Duy, Jan 22, 2018
  2. Junio C HamanoJan 22, 2018
  3. Jeff KingJan 22, 2018
  4. Ævar Arnfjörð BjarmasonJan 23, 2018
  5. Jeff KingJan 23, 2018
  6. Duy NguyenJan 23, 2018
  7. Ævar Arnfjörð BjarmasonJan 23, 2018
  8. 0/2 wrap format-patch diffstats around 72 columnsNguyễn Thái Ngọc Duy, Jan 25, 2018
  9. 1/2 format-patch: keep cover-letter diffstat wrapped in 72 columnsNguyễn Thái Ngọc Duy, Jan 25, 2018
  10. 2/2 format-patch: reduce patch diffstat width to 72Nguyễn Thái Ngọc Duy, Jan 25, 2018
  11. Jeff KingJan 27, 2018
  12. Duy NguyenJan 30, 2018
  13. Jeff KingJan 27, 2018
  14. 0/2 wrap format-patch diffstats around 72 columnsNguyễn Thái Ngọc Duy, Feb 1, 2018
  15. 1/2 format-patch: keep cover-letter diffstat wrapped in 72 columnsNguyễn Thái Ngọc Duy, Feb 1, 2018
  16. 2/2 format-patch: reduce patch diffstat width to 72Nguyễn Thái Ngọc Duy, Feb 1, 2018
  17. Junio C HamanoFeb 2, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.