Re: [PATCH v2 0/6] Force pipes to flush immediately on NonStop platform

From: Torsten Bögershausen <tboegi@web.de>
Date: Jan 20, 2018, 11:10 UTC
Message-ID: <20180120111012.GA26459@tor.lan>
In-Reply-To: <20180119173406.13324-1-randall.s.becker@rogers.com>

On Fri, Jan 19, 2018 at 12:33:59PM -0500, randall.s.becker@rogers.com wrote:

Show 21 quoted lines

> From: "Randall S. Becker" <rsbecker@nexbridge.com>
> 
> * wrapper.c: called setbuf(stream,0) to force pipe flushes not enabled by
>   default on the NonStop platform.
> 
> Signed-off-by: Randall S. Becker <rsbecker@nexbridge.com>
> ---
>  wrapper.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/wrapper.c b/wrapper.c
> index d20356a77..671cbb4b4 100644
> --- a/wrapper.c
> +++ b/wrapper.c
> @@ -403,6 +403,9 @@ FILE *xfdopen(int fd, const char *mode)
>  	FILE *stream = fdopen(fd, mode);
>  	if (stream == NULL)
>  		die_errno("Out of memory? fdopen failed");
> +#ifdef __TANDEM
> +	setbuf(stream,0);
> +#endif

Reading the commit message, I would have expected someting similar to

#ifdef FORCE_PIPE_FLUSHES
	setbuf(stream,0);
#endif

(Because other systems may need the tweak as well, some day) Of course you need to change that in the Makefile and config.mak.uname

Show 6 quoted lines

>  	return stream;
>  }
>  
> -- 
> 2.16.0.31.gf1a482c
>