git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] mru: Replace mru.[ch] with list.h implementation

From
Jeff King <peff@peff.net>
Date
Jan 19, 2018, 21:46 UTC
Message-ID
<20180119214655.GB12074@sigill.intra.peff.net>
In-Reply-To
<1516067185-1087-1-git-send-email-gs051095@gmail.com>
On Mon, Jan 15, 2018 at 08:46:25PM -0500, Gargi Sharma wrote:
Show 9 quoted lines
> Replace the custom calls to mru.[ch] with calls to list.h. This patch is the
> final step in removing the mru API completely and inlining the logic.
> 
> Another discussion, here
> (https://public-inbox.org/git/CAOCi2DGYQr4jFf5ObY2buyhNJeaAPQKF8tbojn2W0b18Eo+Wgw@mail.gmail.com/)
> was on what has to be done with the next pointer of packed git type
> inside the
> packed_git structure. It can be removed _given_ that no one needs to
> access the list in order and can be sent as another patch.

Thanks for picking this up again. I agree that this is probably a good stopping point for now, as I think just combining this with the 'next' pointer may carry more side effects.

Aside from the braces thing that Christian mentioned (and the missing signoff), this all looks good to me.

-Peff
Previous: Junio C HamanoNext: Gargi Sharma
Message 4 of 5 in “mru: Replace mru.[ch] with list.h implementation”
  1. mru: Replace mru.[ch] with list.h implementationGargi Sharma, Jan 16, 2018
  2. Christian CouderJan 19, 2018
  3. Junio C HamanoJan 19, 2018
  4. Jeff KingJan 19, 2018
  5. Gargi SharmaJan 19, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.