git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Replaced read with xread in transport-helper.c to fix SSIZE_MAX overun in t5509

From
Jeff King <peff@peff.net>
Date
Jan 11, 2018, 06:20 UTC
Message-ID
<20180111062048.GA31213@sigill.intra.peff.net>
In-Reply-To
<010f01d38a9e$a5c4f290$f14ed7b0$@nexbridge.com>
On Thu, Jan 11, 2018 at 12:40:05AM -0500, Randall S. Becker wrote:
> This fix was needed on HPE NonStop NSE where SSIZE_MAX is less than
> BUFFERSIZE resulting in EINVAL. The call to read in transport-helper.c
> was the only place outside of wrapper.c.

For my own curiosity, what is SSIZE_MAX on your platform? BUFFERSIZE is only 64k. Do you really have 16-bit size_t?

I wondered if you would also need to set MAX_IO_SIZE, but it looks like we default it to SSIZE_MAX.

-Peff
Previous: Randall S. BeckerNext: Randall S. Becker
Message 3 of 6 in “Replaced read with xread in transport-helper.c to fix SSIZE_MAX overun in t5509”
  1. Replaced read with xread in transport-helper.c to fix SSIZE_MAX overun in t5509Randall S. Becker, Jan 11, 2018
  2. Randall S. BeckerJan 11, 2018
  3. Jeff KingJan 11, 2018
  4. Randall S. BeckerJan 11, 2018
  5. Jeff KingJan 11, 2018
  6. Randall S. BeckerJan 11, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.