git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] oidset: don't return value from oidset_init

From
Thomas Gummerer <t.gummerer@gmail.com>
Date
Jan 7, 2018, 23:04 UTC
Message-ID
<20180107230404.23289-1-t.gummerer@gmail.com>

c3a9ad3117 ("oidset: add iterator methods to oidset", 2017-11-21) introduced a 'oidset_init()' function in oidset.h, which has void as return type, but returns an expression.

This makes the solaris compiler fail with:
    "oidset.h", line 30: void function cannot return value

As the return type is void, and even the return type of the expression we're trying to return (oidmap_init) is void just remove the return statement to fix the compiler error.

Signed-off-by: Thomas Gummerer <t.gummerer@gmail.com>
---
 oidset.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/oidset.h b/oidset.h
index 783abceccd..40ec5f87fe 100644
--- a/oidset.h
+++ b/oidset.h
@@ -27,7 +27,7 @@ struct oidset {
 
 static inline void oidset_init(struct oidset *set, size_t initial_size)
 {
-	return oidmap_init(&set->map, initial_size);
+	oidmap_init(&set->map, initial_size);
 }
 
 /**
-- 
2.16.0.rc1.238.g530d649a79
Next: Junio C Hamano
Message 1 of 3 in “oidset: don't return value from oidset_init”
  1. oidset: don't return value from oidset_initThomas Gummerer, Jan 7, 2018
  2. Junio C HamanoJan 8, 2018
  3. Johannes SixtJan 9, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.