Re: [PATCH 0/2] Several fixes for the test suite related to spaces in filenames
- From
Jeff King <peff@peff.net>
- Date
- Jan 3, 2018, 19:08 UTC
- Message-ID
- <20180103190844.GA30781@sigill.intra.peff.net>
- In-Reply-To
- <cover.1514998470.git.johannes.schindelin@gmx.de>
On Wed, Jan 03, 2018 at 05:54:44PM +0100, Johannes Schindelin wrote:
Show 5 quoted lines
> The second issue was found long ago, and the patch carried in Git for > Windows, although nothing about it is specific to Windows. > > The first patch was developed today, when I tried to verify that Git's > test suite passes if Git is cloned to a directory called `with spaces/`.
Heh, the whole point of the space in the trash directory was to find these issues early, but obviously it is not foolproof. :)
The patches themselves look good to me from inspection. Thanks.
-Peff