Re: [PATCH] http: fix v1 protocol tests with apache httpd < 2.4

From: Jeff King <peff@peff.net>
Date: Jan 3, 2018, 05:56 UTC
Message-ID: <20180103055646.GA25752@sigill.intra.peff.net>
In-Reply-To: <20171231023234.21215-1-tmz@pobox.com>

On Sat, Dec 30, 2017 at 09:32:34PM -0500, Todd Zullinger wrote:

Show 11 quoted lines

> The apache config used by tests was updated to use the SetEnvIf
> directive to set the Git-Protocol header in 19113a26b6 ("http: tell
> server that the client understands v1", 2017-10-16).
> 
> Setting the Git-Protocol header is restricted to httpd >= 2.4, but
> mod_setenvif and the SetEnvIf directive work with lower versions, at
> least as far back as 2.0, according to the httpd documentation:
> 
>     https://httpd.apache.org/docs/2.0/mod/mod_setenvif.html
> 
> Drop the restriction.  Tested with httpd 2.2 and 2.4.

Makes sense. I think the only way this could backfire is if somebody has a funny build that doesn't include mod_setenvif at all. But I don't think we can know that for sure without applying this and seeing if anybody screams.

Show 5 quoted lines

> I removed the version restriction entirely rather than adjust
> the version.  I believe SetEnvIf works on httpd >= 2.0.  I'm
> not sure if we aim to support anything less than httpd 2.0,
> but I'm betting not.  If that's incorrect, I can add some
> IfVersion conditions.

IIRC, anything less than 2.0 is broken already. And it's not worth changing that, given the age (and I think there were some pretty severe hardships in making 1.3.x, but it's been a while).

-Peff