git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: feature-request: git "cp" like there is git mv.

From
SMStefan Moch <stefanmoch@mail.de>
Date
Dec 31, 2017, 19:11 UTC
Message-ID
<20171231191156.28359-1-stefanmoch@mail.de>
In-Reply-To
<20171216013130.GB188893@aiede.mtv.corp.google.com>
* Jonathan Nieder <jrnieder@gmail.com> [2017-12-15T17:31:30-0800]:
Show 7 quoted lines
> This sounds like a reasonable thing to add.  See builtin/mv.c for how
> "git mv" works if you're looking for inspiration.
> 
> cmd_mv in that file looks rather long, so I'd also be happy if someone
> interested refactors to break it into multiple self-contained pieces
> for easier reading (git mostly follows
> https://www.kernel.org/doc/html/latest/process/coding-style.html#functions).

I looked at builtin/mv.c and have a rough idea how to split it up to support both mv and cp commands.

But first I noticed and removed a redundant check in cmd_mv, also added a test case to check if mv --dry-run does not move the file.

Stefan
Previous: Jonathan NiederNext: Stefan Moch
Message 5 of 12 in “feature-request: git "cp" like there is git mv.”
  1. Simon DoodkinDec 12, 2017
  2. Johannes SchindelinDec 13, 2017
  3. Randall S. BeckerDec 13, 2017
  4. Jonathan NiederDec 16, 2017
  5. Stefan MochDec 31, 2017
  6. 1/2 Add test case for mv --dry-run to t7001-mv.shStefan Moch, Dec 31, 2017
  7. 2/2 mv: remove unneeded 'if (!show_only)'Stefan Moch, Dec 31, 2017
  8. Junio C HamanoFeb 7, 2018
  9. Stefan BellerFeb 7, 2018
  10. Stefan MochMar 18, 2018
  11. Junio C HamanoMar 19, 2018
  12. Igor DjordjevicDec 18, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.