[PATCH] Fix urlencode format string on signed char.
- From
- Julien Dusser <julien.dusser@free.fr>
- Date
- Dec 22, 2017, 17:24 UTC
- Message-ID
- <20171222172437.19505-1-julien.dusser@free.fr>
Git credential fails with special char in password. remote: Invalid username or password. fatal: Authentication failed for
File ~/.git-credential contains badly urlencoded characters %ffffffXX%ffffffYY instead of %XX%YY.
Add a cast to an unsigned char to fix urlencode use of %02x on a char.
Signed-off-by: Julien Dusser <julien.dusser@free.fr> --- strbuf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/strbuf.c b/strbuf.c index 323c49ceb..4d5a9ce55 100644 --- a/strbuf.c +++ b/strbuf.c @@ -658,7 +658,7 @@ static void strbuf_add_urlencode(struct strbuf *sb, const char *s, size_t len, (!reserved && is_rfc3986_reserved(ch))) strbuf_addch(sb, ch); else - strbuf_addf(sb, "%%%02x", ch); + strbuf_addf(sb, "%%%02x", (unsigned char)ch); } }
-- 2.15.1