git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/4] t/lib-submodule-update.sh: Fix test ignoring ignored files in submodules

From
Stefan Beller <sbeller@google.com>
Date
Dec 20, 2017, 22:17 UTC
Message-ID
<20171220221725.129162-3-sbeller@google.com>
In-Reply-To
<20171220221725.129162-1-sbeller@google.com>

It turns out that this buggy test passed due to the buggy implementation, which will soon be corrected. Let's fix the test first.

Signed-off-by: Stefan Beller <sbeller@google.com>
---
 t/lib-submodule-update.sh | 1 +
 1 file changed, 1 insertion(+)
diff --git a/t/lib-submodule-update.sh b/t/lib-submodule-update.sh
index d7699046f6..fb0173ea87 100755
--- a/t/lib-submodule-update.sh
+++ b/t/lib-submodule-update.sh
@@ -885,6 +885,7 @@ test_submodule_switch_recursing_with_args () {
 		(
 			cd submodule_update &&
 			git branch -t replace_sub1_with_file origin/replace_sub1_with_file &&
+			echo ignored >.git/modules/sub1/info/exclude &&
 			: >sub1/ignored &&
 			$command replace_sub1_with_file &&
 			test_superproject_content origin/replace_sub1_with_file &&
-- 
2.15.1.620.gb9897f4670-goog
Previous: Stefan BellerNext: Stefan Beller
Message 3 of 7 in “[PATCHv2 0/4] Fix --recurse-submodules for submodule worktree changes”
  1. Stefan BellerDec 20, 2017
  2. 1/4 t/lib-submodule-update.sh: clarify testStefan Beller, Dec 20, 2017
  3. 2/4 t/lib-submodule-update.sh: Fix test ignoring ignored files in submodulesStefan Beller, Dec 20, 2017
  4. 3/4 unpack-trees: Fix same() for submodulesStefan Beller, Dec 20, 2017
  5. Junio C HamanoDec 22, 2017
  6. 4/4 submodule: submodule_move_head omits old argument in forced caseStefan Beller, Dec 20, 2017
  7. Junio C HamanoDec 22, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.